add asynchronous implementation #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks - but instead of building in another path to use this particular module, it would be more the pull-stream way to keep this module the same, but write another module that lets you start a stream async. you can that with https://github.com/pull-stream/pull-defer ... but prehaps it could be more obvious? |
|
this was refactored out of patchbay, and 100 ms seemed reasonable in that context, we should definitely change that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an implementation of pull-next that takes an asynchronous Source generator.
I was inspired to write this by a need to stream a succession of Node.js API HTTP response streams.
I do have one additional question: Might we use
setImmediate(more)instead ofsetTimeout(more, 100)? Why 100ms?